Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a binder that can launch different versions of jupyterlab dev builds #20

Merged
merged 23 commits into from
Mar 17, 2021
Merged

a binder that can launch different versions of jupyterlab dev builds #20

merged 23 commits into from
Mar 17, 2021

Conversation

tonyfast
Copy link
Contributor

@tonyfast tonyfast commented Feb 26, 2021 •
edited

Begin adding doit tasks to build a binder. to begin we're gunna steal lots of others have done.

addresses #18

https://gke.mybinder.org/v2/gh/deathbeds/accessibility/binder

@tonyfast
Copy link
Contributor Author

tonyfast commented Mar 3, 2021

I am pretty sure this binder is working now for testing; at least i'm getting the red bar.

I am not sure the best way to verify it is working.

@bollwyvl could you review some of the targets i commented that went to the build folder. i couldn't set those up correct enough to get doit to work.

@tonyfast tonyfast changed the title WIP - begin building a binder that can launch multiple versions of jupyterlab dependences a binder that can launch different versions of jupyterlab dev builds Mar 3, 2021
@jtpio jtpio mentioned this pull request Mar 5, 2021
Closed
@bollwyvl
Copy link
Contributor

@goanpeca raised the point of how the heck do we use this... we can add a README/CONTRIBUTING update, but didn't want to step on any toes as we're moving forward...

@isabela-pf
Copy link
Contributor

I have a draft PR for updating the readme and can add something there if you know what you want. I think @tonyfast could probably also make commits to that PR too since he's in the accessibility organization.

@tonyfast
Copy link
Contributor Author

y'all think we could merge this?

blink1073
blink1073 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, I'm excited to see this in action!

@blink1073 blink1073 merged commit 2a7e502 into jupyter:master Mar 17, 2021
@isabela-pf
Copy link
Contributor

🎉 Ahhhh! I'm so excited. Congrats on merging this and thanks for your work!

@bollwyvl bollwyvl mentioned this pull request Mar 18, 2021
Merged
@m158261 m158261 mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@marthacryan marthacryan Awaiting requested review from marthacryan

@goanpeca goanpeca Awaiting requested review from goanpeca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tonyfast @bollwyvl @isabela-pf @blink1073